Skip to content

Comments

gh-142105: Add keylist argument to list.sort#142106

Closed
dg-pb wants to merge 15 commits intopython:mainfrom
dg-pb:sort_keys
Closed

gh-142105: Add keylist argument to list.sort#142106
dg-pb wants to merge 15 commits intopython:mainfrom
dg-pb:sort_keys

Conversation

@dg-pb
Copy link
Contributor

@dg-pb dg-pb commented Nov 30, 2025

  • Tests
  • Double check error handling
  • What's new + News entries

📚 Documentation preview 📚: https://cpython-previews--142106.org.readthedocs.build/

@dg-pb dg-pb marked this pull request as draft November 30, 2025 04:04
@picnixz
Copy link
Member

picnixz commented Nov 30, 2025

FTR:

  • You need a NEWS + What's New entry.
  • You probably neeed a PEP like PEP-618.

@picnixz
Copy link
Member

picnixz commented Nov 30, 2025

After more thoughts (#142105 (comment)), I'm going to close this one for now. The DPO thread doesn't strike me as enough supportive and I really think we need a PEP for such changes. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants